New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenVINO LLMs #12639
Add OpenVINO LLMs #12639
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
743656c
to
8287eaf
Compare
update the dependancy update toml
Thanks for the contribution @OpenVINO-dev-contest -- haven't taken a closer look yet, but just wondering would LogProbs be available for this LLM integration? |
|
||
@classmethod | ||
def class_name(cls) -> str: | ||
return "HuggingFace_LLM" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the class name HuggingFace_LLM
intended, or should it be something like OpenVino_LLM
?
General comment: Since |
This is great idea, and thanks for your review, have updated it accordingly. |
Hi since this implementation is a subclass of huggingface LLM, its functions will be aligned with HF. |
Thanks for the change! |
removed the conflict dependency to align with HF. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
* first * first * first commit * update colab link update the dependancy update toml * update openvino class * update openvino llm dependency
Description
Add OpenVINO LLMs
Fixes # (issue)
New Package?
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods