Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenVINO LLMs #12639

Merged
merged 6 commits into from Apr 10, 2024
Merged

Add OpenVINO LLMs #12639

merged 6 commits into from Apr 10, 2024

Conversation

OpenVINO-dev-contest
Copy link
Contributor

@OpenVINO-dev-contest OpenVINO-dev-contest commented Apr 8, 2024

Description

Add OpenVINO LLMs

Fixes # (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Apr 8, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

update the dependancy

update toml
@nerdai
Copy link
Contributor

nerdai commented Apr 8, 2024

Thanks for the contribution @OpenVINO-dev-contest -- haven't taken a closer look yet, but just wondering would LogProbs be available for this LLM integration?


@classmethod
def class_name(cls) -> str:
return "HuggingFace_LLM"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the class name HuggingFace_LLM intended, or should it be something like OpenVino_LLM?

@Javtor
Copy link
Contributor

Javtor commented Apr 8, 2024

General comment: Since OpenVINOLLM is very similar to HuggingFaceLLM (only DEFAULT_HUGGINGFACE_MODEL, the constructor, and class_name change) I would much prefer subclassing to avoid code-duplication, and changing the Pydantic fields default values and constructor as needed.

@OpenVINO-dev-contest
Copy link
Contributor Author

Pydantic

This is great idea, and thanks for your review, have updated it accordingly.

@OpenVINO-dev-contest
Copy link
Contributor Author

LogProbs

Hi since this implementation is a subclass of huggingface LLM, its functions will be aligned with HF.

@Javtor
Copy link
Contributor

Javtor commented Apr 9, 2024

Thanks for the change!
There seems to be a dependency conflict with the huggingface_hub version. This pyproject.toml requires huggingface_hub<0.23.0 and >=0.22.2, but the one from llama-index-llms-huggingface requires it to be <0.21.0 and >=0.20.3

@OpenVINO-dev-contest
Copy link
Contributor Author

dependency

removed the conflict dependency to align with HF.

Copy link
Contributor

@Javtor Javtor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 10, 2024
@Javtor Javtor merged commit 7156bcf into run-llama:main Apr 10, 2024
8 checks passed
chrisalexiuk-nvidia pushed a commit to chrisalexiuk-nvidia/llama_index that referenced this pull request Apr 25, 2024
* first

* first

* first commit

* update colab link

update the dependancy

update toml

* update openvino class

* update openvino llm dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants