Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix llama-index-multi-modal-llms-gemini dependency #12645

Merged
merged 1 commit into from Apr 8, 2024

Conversation

nicoloboschi
Copy link
Contributor

Description

Fixes release action problem: https://github.com/run-llama/llama_index/actions/runs/8574427576/job/23501224052
Now both needs 0.4.x of google-generativeai.

This will trigger the 0.1.5 release of llama-index-multi-modal-llms-gemini

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 8, 2024
@nicoloboschi
Copy link
Contributor Author

@logan-markewich PTAL
llama-index-multi-modal-llms-gemini must be released as soon as possible

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 8, 2024
@nerdai
Copy link
Contributor

nerdai commented Apr 8, 2024

@nicoloboschi I believe we still need to update the version number of this package as well in the pyproject.toml

@nicoloboschi
Copy link
Contributor Author

IIUC the release action is performed if there is a change in the pyproject file. The current version never reached pypi so I believe that just merging this pr should be fine.

@nerdai
Copy link
Contributor

nerdai commented Apr 8, 2024

IIUC the release action is performed if there is a change in the pyproject file. The current version never reached pypi so I believe that just merging this pr should be fine.

ah yes, you're right it didn't reach pypi. Okay let's give it a whirl. If it doesn't go thru our github actions I can publish/build manually for us.

@nerdai nerdai merged commit 830d0b3 into run-llama:main Apr 8, 2024
8 checks passed
chrisalexiuk-nvidia pushed a commit to chrisalexiuk-nvidia/llama_index that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants