New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax dependency version to accept astrapy 1.* #12792
Conversation
…cated method call
|
||
@pytest.fixture(scope="module") | ||
def source_collection_name() -> Iterable[str]: | ||
COLLECTION_NAME = "li_readers_test" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe at this point the COLLECTION_NAME
could be a module constant and source_collection_name
become an auto_use
fixture ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion. Done :)
|
||
|
||
@pytest.fixture(autouse=True, scope="module") | ||
def source_collection() -> Iterable[str]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type is a collection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you - fix is landed along with a couple other things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the version (patch) number for the two packages in their respective pyproject.toml files. 🙏
I see dependency trouble running the tests - despite what is seen in the pyproject.toml's. Import lines such as |
Could be a pants-related thing. Attn: @logan-markewich any thoughts here? |
That should fix it, just made astrapy an explicit dep of the tests |
Description
The main point of this PR is to allow for astrapy 1.* (now that 1.0.0 is out).
This version is backward-compatible so no code changes are needed.
delete
=>delete_one
).Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods