fix: wrong doc id when using default s3 endpoint in S3Reader #12803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
raghavdixit99
pushed a commit
to raghavdixit99/llama_index_lance
that referenced
this pull request
Apr 13, 2024
…ma#12803) * use none as default * fix doc id * bump version
chrisalexiuk-nvidia
pushed a commit
to chrisalexiuk-nvidia/llama_index
that referenced
this pull request
Apr 25, 2024
…ma#12803) * use none as default * fix doc id * bump version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The line
doc.id_ = self.s3_endpoint_url + "_" + doc.id_was failing when using the default s3_endpoint_url, since it's None. Added a check for that case