Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose azure_ad_token_provider argument to support token expiration #12818

Merged

Conversation

gregory-shklover
Copy link
Contributor

Description

Expose openai.AzureADTokenProvide attribute for AzureOpenAI models (LLM and embedding).
Corresponding "azure_ad_token_provider" callback can handle token expiration, which is not handled otherwise.

Fixes # (issue)
No separate issue submitted.

New Package?

No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ran manual testing in within private azure-hosted deployment

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 14, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 15, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) April 15, 2024 18:10
@logan-markewich logan-markewich enabled auto-merge (squash) April 15, 2024 18:13
@logan-markewich logan-markewich merged commit 2cb207a into run-llama:main Apr 15, 2024
8 checks passed
@gregory-shklover gregory-shklover deleted the gshklover_token_provider branch April 16, 2024 06:05
chrisalexiuk-nvidia pushed a commit to chrisalexiuk-nvidia/llama_index that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants