Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: batch insertions into Milvus vector store #12837

Merged
merged 4 commits into from Apr 15, 2024

Conversation

gblazq
Copy link
Contributor

@gblazq gblazq commented Apr 15, 2024

Description

Insertions into the Milvus vector store were previously done in a single batch, with the risk of hitting a resource exhaustion error. Pymilvus doesn't have support for batches so we must create the batches ourselves to avoid this issue. Default batch size is set to 100 to mimic the Pinecone vector store.

Fixes #12831

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 15, 2024
@gblazq gblazq changed the title Batch insertions into Milvus vector store fix: batch insertions into Milvus vector store Apr 15, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 15, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) April 15, 2024 18:22
@logan-markewich logan-markewich merged commit 2f3828f into run-llama:main Apr 15, 2024
8 checks passed
chrisalexiuk-nvidia pushed a commit to chrisalexiuk-nvidia/llama_index that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Resource exhausted error when inserting data into Milvus
2 participants