Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

see #12874: provide the exception to the StreamChatErrorEvent #12879

Conversation

ziodave
Copy link
Contributor

@ziodave ziodave commented Apr 16, 2024

Description

The StreamChatErrorEvent now provides the exception that caused the error.

Fixes #12874

New Package?

  • Yes
  • No

Version Bump?

  • Yes
  • No

Type of Change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 16, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 16, 2024
@logan-markewich logan-markewich merged commit 9e40a9d into run-llama:main Apr 16, 2024
8 checks passed
@logan-markewich
Copy link
Collaborator

Thanks @ziodave !

chrisalexiuk-nvidia pushed a commit to chrisalexiuk-nvidia/llama_index that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: StreamChatErrorEvent() to provide the inner exception
2 participants