Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AsyncOpenAI "RuntimeError: Event loop is closed bug" when instances of AsyncOpenAI are rapidly created & destroyed #12946

Merged
merged 5 commits into from
Apr 19, 2024
Merged

Fix AsyncOpenAI "RuntimeError: Event loop is closed bug" when instances of AsyncOpenAI are rapidly created & destroyed #12946

merged 5 commits into from
Apr 19, 2024

Commits on Apr 18, 2024

  1. wrap all completions requests in client or aclient context manager to… 

    … avoid openai/openai-python#1262
    @philipchung
    philipchung committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    b49bd9e View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. only uses client context block if reuse_client=False since leaving co… 

    …ntext closes client's connection pool; do not use client context in streaming methods
    @philipchung
    philipchung committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    7b2ae34 View commit details
    Browse the repository at this point in the history

  2. only use client context manager if reuse_client=False, otherwise clie… 

    …nt's connection pool will be closed; context manager not used for streaming methods
    @philipchung
    philipchung committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    ec87d5d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'FixAsyncOpenAIRuntimeError' of https://github.com/phili… 

    …pchung/llama_index into FixAsyncOpenAIRuntimeError
    @philipchung
    philipchung committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    b2d3f08 View commit details
    Browse the repository at this point in the history

  4. vbump

    @logan-markewich
    logan-markewich committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    9fa87b4 View commit details
    Browse the repository at this point in the history