Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude access control metadata keys from LLMs and embeddings - SharePoint Reader #13184

Merged
merged 6 commits into from Apr 30, 2024
Merged

Exclude access control metadata keys from LLMs and embeddings - SharePoint Reader #13184

merged 6 commits into from Apr 30, 2024

Conversation

Javtor
Copy link
Contributor

@Javtor Javtor commented Apr 30, 2024

Description

Exclude access control metadata keys from LLMs and embeddings - SharePoint Reader

Version Bump?

  • Yes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 30, 2024
nerdai
nerdai approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 30, 2024
yisding
yisding approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@yisding yisding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Javier! This will work, but for the more general use case we probably want to have an interface in the loader or splitter to set these variables I think.

@yisding yisding merged commit dd3a25c into main Apr 30, 2024
8 checks passed
@yisding yisding deleted the javier/sharepoint-add-metadata branch April 30, 2024 21:14
JuHyung-Son pushed a commit to UpstageAI/llama_index that referenced this pull request May 1, 2024
@Javtor @JuHyung-Son
Exclude access control metadata keys from LLMs and embeddings - Share…
554d32f 
…Point Reader (run-llama#13184)

* add access control metadata

* version bump

* add attach_permision flag

* exclude keys

* version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yisding yisding yisding approved these changes

@nerdai nerdai nerdai approved these changes

@logan-markewich logan-markewich Awaiting requested review from logan-markewich

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Javtor @yisding @nerdai