Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Spider Web Loader #13200

Merged
merged 12 commits into from May 6, 2024
Merged

feat: Spider Web Loader #13200

merged 12 commits into from May 6, 2024

Conversation

WilliamEspegren
Copy link
Contributor

@WilliamEspegren WilliamEspegren commented May 1, 2024

Description

Added SpiderWebLoader, the fastest and cheapest crawler that returns LLM-ready data.

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end) (added in existing notebook)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@WilliamEspegren WilliamEspegren marked this pull request as ready for review May 1, 2024 20:05
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 1, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 3, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) May 3, 2024 15:40
auto-merge was automatically disabled May 3, 2024 16:57

Head branch was pushed to by a user without write access

@WilliamEspegren
Copy link
Contributor Author

@logan-markewich now lint and the unit test should pass

@WilliamEspegren
Copy link
Contributor Author

@logan-markewich anything blocking this?

@nerdai
Copy link
Contributor

nerdai commented May 6, 2024

merging this now @WilliamEspegren and @logan-markewich!

@nerdai nerdai merged commit c922587 into run-llama:main May 6, 2024
8 checks passed
@WilliamEspegren
Copy link
Contributor Author

@nerdai the version must be bumped:

Change this line to 01.1.13

@nerdai
Copy link
Contributor

nerdai commented May 6, 2024

Ah shucks. My bad. Can you submit another PR to bump version?

@WilliamEspegren
Copy link
Contributor Author

Ah shucks. My bad. Can you submit another PR to bump version?

Here you go: #13301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants