New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Community] Add streaming for maritalk #13207
Merged
logan-markewich
merged 8 commits into
run-llama:main
from
maritaca-ai:feature/add-maritalk-streaming
May 3, 2024
Merged
[Community] Add streaming for maritalk #13207
logan-markewich
merged 8 commits into
run-llama:main
from
maritaca-ai:feature/add-maritalk-streaming
May 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add usage of model name parameter * Add error handling specific for maritalk API * Add complete methods for streaming and non streaming
* Add examples for chat sync and async * Add examples for complete sync and async * Add examples for streaming
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
May 1, 2024
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
llama-index-integrations/llms/llama-index-llms-maritalk/README.md
Outdated
Show resolved
Hide resolved
llama-index-integrations/llms/llama-index-llms-maritalk/llama_index/llms/maritalk/base.py
Outdated
Show resolved
Hide resolved
Hello @logan-markewich, All reviews applied. Thanks for the feedback! |
logan-markewich
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements both sync and async methods for streaming and non-streaming functionality within the
maritalk
package.Adds a README file directing users to a refactored notebook that tests end-to-end these new features.
Introduces a new parameter,
model
, to themaritalk
model.Implements specific error handling for the
maritalk
API.New Package?
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods