Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Community] Add streaming for maritalk #13207

Merged

Conversation

RosevalJr
Copy link
Contributor

Description

This PR implements both sync and async methods for streaming and non-streaming functionality within the maritalk package.

Adds a README file directing users to a refactored notebook that tests end-to-end these new features.

Introduces a new parameter, model, to the maritalk model.

Implements specific error handling for the maritalk API.

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

* Add usage of model name parameter
* Add error handling specific for maritalk API
* Add complete methods for streaming and non streaming
* Add examples for chat sync and async
* Add examples for complete sync and async
* Add examples for streaming
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 1, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@RosevalJr
Copy link
Contributor Author

Hello @logan-markewich,

All reviews applied. Thanks for the feedback!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 3, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) May 3, 2024 00:37
@logan-markewich logan-markewich merged commit b6fe03c into run-llama:main May 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants