Fix + small addition to SimpleDirectoryReader #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryjliu
reviewed
Jan 12, 2023
|
(btw i can also do it, will have some time later today) |
|
Yep I'll be working on some stuff later today and I'll also write the tests |
|
@emptycrown oops i got excited and already added tests, but please take a look! |
|
Yep, lgtm! |
viveksilimkhan1
pushed a commit
to viveksilimkhan1/llama_index
that referenced
this pull request
Oct 30, 2023
* Fix regex -> re import. (run-llama#205) * Add 'gpu' marker. (run-llama#208) * Optional authentation verification at init time (run-llama#206) * Add verify_auth param. * Add _verify_auth() for Cohere and Anthropic. * Make auth check mandatory again. * Remove redundant PR. * Fix OpenLLaMA model names (run-llama#209) * Update PR template. (run-llama#207) * Update OpenLLaMA model names. * fix model name in documentation (run-llama#210) * Bump version to 0.4.1. (run-llama#211) --------- Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
recursiveattribute was not being used. The reader always recursively read subdirectories even though the attribute isFalseby default. This is fixed.I also added a new attribute to limit the number of files added to the reader when the recursion can go deep. The recursion still finishes (not a worry) but it avoids having too many Documents created. I switched the resulting
new_input_filesarray to reflect BFS instead of DFS and so the file limit prioritizes top-level files.