Add LLM abstraction #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoh
reviewed
Dec 2, 2022
| @@ -62,7 +62,7 @@ def __init__( | |||
| chunk_size=chunk_size, | |||
| chunk_overlap=MAX_CHUNK_OVERLAP, | |||
| ) | |||
| super().__init__(documents=documents, index_struct=index_struct) | |||
| super().__init__(documents=documents, index_struct=index_struct, **kwargs) | |||
There was a problem hiding this comment.
For my understanding only: why did we make this a general kwargs? From what i can tell, in the BaseGPTIndex constructor we just added llm_predictor. https://github.com/jerryjliu/gpt_index/blob/main/gpt_index/indices/base.py#L58
There was a problem hiding this comment.
Yeah it was mostly because I was lazy, in case any additional arguments popped up...I didn't lump documents/index_struct into kwargs because they're in first position in the arguments.
Actually probably not a bad idea to be explicit instead of using kwargs here. I'll take a look at cleaning this up as an additional TODO
viveksilimkhan1
pushed a commit
to viveksilimkhan1/llama_index
that referenced
this pull request
Oct 30, 2023
* ini declarations and proper python installs * flip openai/dolly example * Apply suggestions from code review Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com> --------- Co-authored-by: svlandeg <svlandeg@github.com> Co-authored-by: Raphael Mitsch <r.mitsch@outlook.com> Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
logan-markewich
added a commit
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of openai_llm_predict and allow user to specify a more general LLM predictor (using any LLM from langchain)