Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix required function fields #6761

Merged
merged 2 commits into from
Jul 7, 2023
Merged

fix required function fields #6761

merged 2 commits into from
Jul 7, 2023

Conversation

yisding
Copy link
Contributor

@yisding yisding commented Jul 6, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • [X ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [X ] Added new unit/integration tests

Suggested Checklist:

  • [X ] I have performed a self-review of my own code
  • [X ] My changes generate no new warnings
  • [X ] I have added tests that prove my fix is effective or that my feature works
  • [X ] New and existing unit tests pass locally with my changes

@yisding yisding marked this pull request as draft July 6, 2023 22:28
@yisding yisding marked this pull request as ready for review July 6, 2023 22:44
Copy link
Collaborator

@Disiok Disiok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look super closely, but tests checks out, and if mypy is satisfied then LGTM

@Disiok Disiok merged commit 2b2046c into run-llama:main Jul 7, 2023
8 checks passed
wey-gu pushed a commit to wey-gu/llama_index that referenced this pull request Jul 11, 2023
* fix required function fields

* use union type and casts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants