fix llama2 in query engines #6969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
Disiok
reviewed
Jul 19, 2023
| context_window=self._context_window, num_output=self._max_tokens | ||
| context_window=self._context_window, | ||
| num_output=self._max_tokens, | ||
| model_name=self._model, |
There was a problem hiding this comment.
I don't think this is a valid field for LLMMetadata?
There was a problem hiding this comment.
It is, merged a thingy today
Disiok
reviewed
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Llama2 needs some very specific formatting. Our chat endpoints used the proper formatting, but the completion endpoints did not.
This PR adds that, plus a notebook, plus fixing the kwarg names for
max_lengthvs.context_windowType of Change
How Has This Been Tested?