Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DynamoDBDocstoreDemo notebook description #6974

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Update DynamoDBDocstoreDemo notebook description #6974

merged 1 commit into from
Jul 20, 2023

Conversation

hwuiwon
Copy link
Contributor

@hwuiwon hwuiwon commented Jul 20, 2023

Description

Added vector_store to StorageContext to load vector_index from DynamoDB storage. Current description will not load vector_store from the DynamoDB table. It also includes one small typo fix.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@logan-markewich logan-markewich merged commit 7e39484 into run-llama:main Jul 20, 2023
8 checks passed
junying1 pushed a commit to junying1/llama_index that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants