Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help new contributers by adding CONTRIBUTING.md. #32

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Help new contributers by adding CONTRIBUTING.md. #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
561b820
Create CONTRIBUTING.md
justindhillon Nov 27, 2023
bee87ad
Update README.md
justindhillon Nov 27, 2023
930cb3c
Update CONTRIBUTING.md
justindhillon Nov 27, 2023
45cb0b3
Merge branch 'main' into main
jerryjliu Nov 28, 2023
248cb02
ran make format; make lint
justindhillon Nov 30, 2023
c464a0c
added format your code to contributing.md
justindhillon Nov 30, 2023
bc9bfe0
fixed numbering
justindhillon Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
Contributing
============

1. Fork it
2. Create your feature branch (`git checkout -b my-new-feature`)
3. Test your changes (`ruff check .`)
4. Format your code (`make format; make lint`)
5. Commit your changes (`git commit -am 'Add some feature'`)
6. Push to the branch (`git push origin my-new-feature`)
7. Create new Pull Request
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ You can set the configuration either through natural language or manually for bo

## Resources

Running into issues? Please file a GitHub issue or join our [Discord](https://discord.gg/dGcwcsnxhU).
Running into issues? Please file a GitHub issue or join our [Discord](https://discord.gg/dGcwcsnxhU). Want to contribute? Learn how by reading [CONTRIBUTING.md](https://github.com/run-llama/rags/blob/main/CONTRIBUTING.md).

This app was built with [LlamaIndex Python](https://github.com/run-llama/llama_index).

Expand Down
1 change: 0 additions & 1 deletion agent_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,6 @@ def update_agent(
def load_meta_agent_and_tools(
cache: Optional[ParamCache] = None,
) -> Tuple[BaseAgent, RAGAgentBuilder]:

# think of this as tools for the agent to use
agent_builder = RAGAgentBuilder(cache)

Expand Down
1 change: 0 additions & 1 deletion pages/2_⚙️_RAG_Config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ def delete_agent() -> None:
st.session_state.config_agent_builder = agent_builder

if agent_builder is not None:

st.info(f"Viewing config for agent: {agent_builder.cache.agent_id}", icon="ℹ️")

agent_id_st = st.text_input(
Expand Down