Extract parser #24
Merged
Extract parser #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change required introducing some other files: - The generic cb_utils.h/.c for stuff that's genuinely used from many places and doesn't really fit anywhere (hope this stays small...). - cb_c_blocks_data.h for the c_blocks_data definition. This is an artifact of c_blocks_data being a bit of a god object. Ideally, we could get rid of this one.
In a nutshell: "Public" functions are cb_ prefixed. Private ones are made static. Due to the size of this .c file and the number of private functions, make sure to declare all functions at the top to avoid any sort of function order dependencies that add cognitive overhead when coding.
|
v5.14 doesn't have |
|
Took me a few attempts, but I got it, finally. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.