Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For PRs with multiple plans, deleting a plan prevents the rest from applying #1415

Open
zhimsel opened this issue Feb 17, 2021 · 2 comments
Open
Labels
feature New functionality/enhancement

Comments

@zhimsel
Copy link

zhimsel commented Feb 17, 2021

Atlantis version: 0.15.1

Example: Consider a PR with 6 separate state directories, which results in 6 plans and locks being created when running atlantis plan. I then review the plans and determine that one of them should not be applied by Atlantis. I then delete just that plan/lock (via the web UI, though I imagine it doesn't matter). Running atlantis apply then fails, with a "Applied 0 plans" comment. Trying again (by re-planning and deleting the offending plan) but just applying a single project (atlantis apply -p ...) fails with "no working directory found–did you run plan?".

I then have to atlantis plan -p ... for each of the desired projects and then apply. For small PRs, this isn't terrible, but imagine one with dozens of projects...

@nishkrishnan
Copy link
Contributor

Yeah it's the nature of how Atlantis clones repos. Unlock deletes the whole repo since otherwise, it'd be difficult to know when to clean up after itself without changing how the data is stored.

Definitely a good improvement though.

@nishkrishnan nishkrishnan added the feature New functionality/enhancement label Feb 25, 2021
@endzyme
Copy link

endzyme commented Mar 8, 2021

Could the same thing be achieved with exclusion syntax or inclusion syntax. I am thinking something like reading more than one -p in atlantis apply -p some/path/1 -p some/path/2 or exclusions like atlantis apply -N some/undesired/path (-N for not-path). Thoughts welcome but the overall goal would be to apply some states, or plan some states and not others. This would all be outside of the scope or auto-merge, I would think if a user wants to be clever and apply a selected states, and not others, they can handle the merge themselves.

Again, thoughts welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement
Projects
None yet
Development

No branches or pull requests

3 participants