atlantis apply should apply all unapplied plans

[chaseconey]

Hello there,

Just upgraded to Atlantis 0.4.0 and the autoplan feature is working nicely, but it seems that when going to apply the planned feature after approval it isn't tracking like it did in 0.3.8.

Steps to error:

• Make change in terraform project
• Make pull request
• Autoplan runs properly on the sub-directory and output looks good
• Reviewer adds approval
• Run command atlantis apply and receive error:

Ran Apply in dir: . workspace: default
Apply Error

no plan found at path "." and workspace "default"–did you run plan?

[lkysow]

@chaseconey right, I think maybe it should be changed back to atlantis apply apply'ing all outstanding plans and atlantis apply -d/-w applying a specific plan. Let me look into that and until then you'll have to use the -d flag.

[chaseconey]

Yeah that is how I ended up getting around it. Let me know if you need any other info!

Thanks

[rmldsky]

@lkysow additionally it seems running manually atlantis plan has the same problem:

Ran Plan in dir: . workspace: default
Plan Error

I mean it expects user to provide -d, even though automated plan ran as expected in dirs/subdirs where changes have been made. It is confusing just because all documentation and guides mention just running atlantis plan and atlantis apply without any flags, which I believe was a case before 0.4.0 release.

Thanks for all the hard work! :)

[lkysow]

Thanks Dawid, yes they should both be changed to plan all/apply all

[bentterp]

I believe the default should be that approving a pull request should only lead to those changes being carried out. I.e. only that specific plan should be applied

Imagine if approving a pull request would merge all code from all open pull requests into the master branch. I don't see people liking that feature being rolled out on GH.

Of course, the default could be configurable.

All in all, it looks like Atlantis could be a really good, free alternative to TF Enterprise. I'm impressed!

[oba11]

@bentterp thought of thesame thing as well. It would be nice to have autoapply once a PR is approved.
It works brilliantly for me, running it in fargate with custom modules. Thank you @lkysow 🥇

[lkysow]

Closed by #216 and available in the latest release: v0.4.5.