Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If autoplan is disabled atlantis still comments #183

Closed
lkysow opened this issue Jul 13, 2018 · 0 comments
Closed

If autoplan is disabled atlantis still comments #183

lkysow opened this issue Jul 13, 2018 · 0 comments

Comments

@lkysow
Copy link
Member

lkysow commented Jul 13, 2018

Currently, Atlantis will add a comment when autoplanning, even if it determines there's nowhere to run plan so that if users were expecting Atlantis to do something that they at least know that it's working versus wondering if it never got the event.

However in the case where a user has explicitly disabled autoplanning via an atlantis.yaml file, we shouldn't add the comment:

Ran `plan` in 0 projects because Atlantis detected no Terraform changes
@lkysow lkysow mentioned this issue Jul 16, 2018
Merged
jamengual pushed a commit that referenced this issue Nov 23, 2022
@msarvar
Orca 4417 refactor merge config (#183)
78eea78 
* Add platform mode flag to GlobalCfg

* Added server side config support for platform mode

* Adding flag to enable platform mode

* fix tests

* Moved some of the project level validations to project struct

Added platform mode config support for project level workflow overrides.
We do not support custom platform mode workflows on repo configs

* fix broken test

* moved validations to repo_cfg

* moved some repetitive code to helper functino

* remove platform mode changes

* clean up for loop

* remove platform mode values from project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lkysow