multienv Fails if Env Vars Contain , (comma) Character

[acostaedg]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

Overview of the Issue

@austinsherron

Hello, I'm facing similar issue with Env vars added through multienv containing the comma (,) character, the error is the following:

{"level":"error","ts":"2022-12-09T14:15:30.592Z","caller":"events/instrumented_project_command_runner.go:42","msg":"Error running plan operation: Invalid environment variable definition:

My variables is something like this:

VARIABLE_NAME=hello, world, this, is, not, working

As the variable "VARIABLE_NAME" value contains comma (,) characters, looks like multienv cannot do the job and create the environment variables correctly.

Reproduction Steps

Logs

Environment details

If not already included, please provide the following:

• Atlantis version: v0.21

Additional Context

This issue is similar to #2351 , in that case the issue was with equal (=) character, in this new issue reported the problem is with comma (,) character and multienv in the atlantis.yaml file.

[nitrocode]

Please share your yaml configurations and any related configs/flags. We may not be able to work on this but this will help contributors in the future be able to propose a PR to fix the issue.

[yiranyao]

Hello, I'm also seeing similar issue when the environment variable contains single (') or double-quote (").
For example

cat .multienv
OWNER=Harry's
PASSWORD=abcd"efg

[inkel]

I can confirm this fails. In fact, I've a test case that proves it. I'm actually working on implementing multienv steps in our workflows and found this issue, so if that's ok with you I'll be working on a fix for all these issues (commas and quotes).

[jamengual]

of course is ok, we will be happy to review @inkel

[inkel]

@jamengual thanks, great to hear. Just out of curiosity: any particular reason why multienv expects a single line of output in the var1=value1,var2=value2 format and not multi-line?

[jamengual]

you must ask @tapaszto , I can't recall the use case.
I remember was initially implemented with a JSON output and then we asked to change it, but that is all I remember.