Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

long plan output does not get sent to github comments #55

Closed
jdeprin opened this issue Mar 7, 2018 · 5 comments
Closed

long plan output does not get sent to github comments #55

jdeprin opened this issue Mar 7, 2018 · 5 comments

Comments

@jdeprin
Copy link

jdeprin commented Mar 7, 2018

I have a repository where there are several changes, when I run the atlantis plan step the plan passes but no plan output is commented on the pull request. I believe this may be is due to the length of the output.

If I run atlantis plan with -target=some.resource the plan passes and output is commented as expected. The full plan output is never posted. tfplan files are created as expected.

I am running Atlantis in a container FROM runatlantis/atlantis. I started atlantis server with --log-level debug but it does not show any comment posts from atlantis to github.

@lkysow
Copy link
Member

lkysow commented Mar 7, 2018

Can you find out how many characters the plan file is? You can find it on the docker container in the same location as when you use -target. I'm wondering if it's a github api issue or on the Atlantis side when it tries to post it.

@jdeprin
Copy link
Author

jdeprin commented Mar 7, 2018

bash-4.3# wc -c ./default.tfplan
2685681 ./default.tfplan

lkysow added a commit that referenced this issue Mar 14, 2018
Fixes #55. GitHub will throw an error if the comment is over
65535 characters. Now we will split up a comment into multiple
comments if it's over that size.
@lkysow
Copy link
Member

lkysow commented Mar 14, 2018

@jdeprin sorry for the delay on this. The problem was indeed on the Atlantis side. GitHub has a max of 65,535 characters per comment. I've fixed this in the latest release to split too long comments into multiple comments.

@msacchiPPRO
Copy link

This is still an issue for gitlab. Should it be a separate issue?

@lkysow
Copy link
Member

lkysow commented Oct 5, 2020

Yes please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants