write-git-creds doesnt appear to work as indicated

[jseiser]

Version 10.2, and I have set write-git-creds to true.

What does work

"git::https://bitbucket.org/repo/tf_modules.git//module_name"

What Does not work

"git::ssh://git@bitbucket.org/repo/tf_modules.git//module_name"

This reads to me like it should work, #799

Im using SSH, and it will do some replacments to use the git-creds it wrote to file.

If im mistaken, please let me know. Thanks.

[lkysow]

@ImperialXT should that work?

[andrewjeffree]

I’ll have a look. But I think so...

…

On Thu, 12 Dec 2019 at 10:41 am, Luke Kysow ***@***.***> wrote: @ImperialXT <https://github.com/ImperialXT> should that work? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#873?email_source=notifications&email_token=AAOARNPVTW3GBTKTO6JW4FTQYF3DHA5CNFSM4JVNLNQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGU6N6Q#issuecomment-564782842>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOARNKQQPVYS737R65X363QYF3DHANCNFSM4JVNLNQA> .

[andrewjeffree]

Right so yes this is a bug. I don't use bitbucket so I didn't look very closely at it when I wrote the initial code. I'm actually surprised that "git::https://bitbucket.org/repo/tf_modules.git//module_name" works as I can't even get that to work with my testing.

The issue appears to be that when calling WriteGitCreds in server/server.go I provide it with the BitBucketBaseURL value which if not set by the user defaults to "https://api.bitbucket.org" and WriteGitCreds takes that literally and writes out credits using that full url and hostname etc.

@lkysow I'd appreciate your feedback on how best to fix this.

I could just have an extra conditional when I'm calling WriteGitCreds for bitbucket where I check if the value BitBucketBaseURL is "https://api.bitbucket.org" and if so pass "bitbucket.org" instead to WriteGitCreds.

An alternative would be to potentially look at changing BitBucketBaseURL to default to "bitbucket.org" and then have a BitBucketAPIUrl variable or similar which we set to "api.bitbucket.org" and is used where needed but this would require changes in many places etc.

[lkysow]

I think put the conditional inside server.go right before you call WriteGitCreds. Then that function can remain "dumb" in terms of not knowing about each vcs.