fix: allowed regexp prefixes for exact matches #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not on the allowed list
bmbferreira
changed the title
|
@chenrui333 can you review this fix? |
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
* test: adds failing test case * fix: return project if there's an exact match, even if the prefix is not on the allowed list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you can see on the test case I added on this pull request, if the user comments for example
atlantis apply -p prod/myprojectit would fail if he didn't addprodon theallowed_regexp_prefixesconfig (added on https://github.com/runatlantis/atlantis/pull/1884/files). 😞This PR fixes that to only check the
allowed_regexp_prefixesonly if there's more than one match for the regex inserted on the PR comment. If it's an exact match, it should ignore theallowed_regexp_prefixes.