fix(github): allow Github App to clone forks of a private repository #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuasimon-taulia
force-pushed
the
master
branch
6 times, most recently
from
9552950
to
1d2317b
Compare
fix: only fetch "pull/$PR_NUMBER/head" when githubAppEnabled
joshuasimon-taulia
force-pushed
the
master
branch
from
1d2317b
to
832f666
Compare
|
@nishkrishnan @chenrui333 @jamengual could i get some feedback? |
chenrui333
reviewed
Mar 3, 2022
|
@joshuasimon-taulia looks pretty straightforward, can you please add some tests? It should be good to go after that. 🙏 |
|
are there any existing test cases i can easily copy/paste from? i took a peek into https://github.com/runatlantis/atlantis/blob/7a927c050b945ccae64850f327c1309c2448aa2a/server/events/github_app_working_dir_test.go, but i don’t see an immediately obvious way to mock a private github fork. |
|
Alright, that is fine then. |
chenrui333
approved these changes
Mar 7, 2022
chenrui333
changed the title
|
thanks for the contribution @joshuasimon-taulia |
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
…ntis#2044) fix: only fetch "pull/$PR_NUMBER/head" when githubAppEnabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1696
i baked an image with my changes. running atlantis against private forks now works in my installation