Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid values for TARGETPLATFORM. #2223

Merged
merged 1 commit into from May 13, 2022

Conversation

Skeen
Copy link
Contributor

@Skeen Skeen commented Apr 26, 2022

Report an error during docker build if TARGETPLATFORM has an unexpected
value.

Report an error during `docker build` if `TARGETPLATFORM` has an unexpected
value.
@Skeen Skeen requested a review from a team as a code owner April 26, 2022 11:07
@Skeen
Copy link
Contributor Author

Skeen commented Apr 26, 2022

Prints ERROR: 'TARGETPLATFORM' value expected: when TARGETPLATFORM is unset.
Prints ERROR: 'TARGETPLATFORM' value expected: linux/ramips when TARGETPLATFORM is Ralink MIPS.

@Skeen
Copy link
Contributor Author

Skeen commented Apr 26, 2022

@jamengual
Copy link
Contributor

LGTM

@jamengual jamengual merged commit d23f7d4 into runatlantis:master May 13, 2022
@jamengual
Copy link
Contributor

krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
Report an error during `docker build` if `TARGETPLATFORM` has an unexpected
value.
@nitrocode nitrocode added this to the v0.19.4 milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants