Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: homepage link on project job output page #2262

Merged
merged 2 commits into from
May 19, 2022

Conversation

ascandella
Copy link
Contributor

Currently the link goes to "" on my install, which browsers interpret as
the current page. Looking at the other templates in this file, it was
missing a trailing /.

Currently the link goes to "" on my install, which browsers interpret as
the current page. Looking at the other templates in this file, it was
missing a trailing `/`.
@ascandella ascandella requested a review from a team as a code owner May 17, 2022 15:46
@ascandella
Copy link
Contributor Author

Example of other template:

<a title="atlantis" href="{{ .CleanedBasePath }}/"><img class="hero" src="{{ .CleanedBasePath }}/static/images/atlantis-icon_512.png"/></a>

@ascandella ascandella changed the title Fix homepage link on project job output page fix: homepage link on project job output page May 17, 2022
@chenrui333 chenrui333 merged commit 80ac130 into runatlantis:master May 19, 2022
@chenrui333
Copy link
Member

Thanks @ascandella!

@ascandella ascandella deleted the link-to-home branch May 19, 2022 00:19
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
Currently the link goes to "" on my install, which browsers interpret as
the current page. Looking at the other templates in this file, it was
missing a trailing `/`.
@nitrocode nitrocode added this to the v0.19.4 milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants