Removing the check about whether a slack channel exists #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pkaramol so what happens if the channel does not exist? does altlantis could still get rate limit or blocked because is trying to send messages to a non existing channel that could be like a DDOS? |
jamengual
added
waiting-on-response
|
@jamengual what will happen is just a send failure here. I have used this client many times and it just errors our, no connection with any DDoS imho. |
|
@jamengual should we proceed with this one? anything else needed? |
|
yes, sorry, I forgot to merged foe the prerelese |
Νο problem and thanks for the review |
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
woodonggyu
pushed a commit
to woodonggyu/docker-atlantis
that referenced
this pull request
Dec 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the check about the existence of a slack channel.
This is done to:
channels:readscope to the corresponding bot (this is a broad scope and many orgs may be reluctant providing it)conversations.listendpoint that has a lower rate limit that may be also related to this issue