Getting working workspace from Terraform Cloud configuration #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cucxabong
changed the title
cucxabong
force-pushed
the
fix-issue-2171
branch
4 times, most recently
from
f49c823
to
52d279f
Compare
cucxabong
force-pushed
the
fix-issue-2171
branch
from
52d279f
to
b25a955
Compare
jamengual
added
waiting-on-review
lilincmu
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
This looks good to me! Thanks for your contribution 🎉
I'd like to point out two minor things, to bring people's attention.
- In the original issue, Atlantis does not detect terraform cloud workspace from cloud config #2171, the author expects the workspace name can be auto detected with
atlantis plan -d .. However, I think this change will not make it work, since this change only modifies thebuildPlanAllCommandscode path but notbuildProjectPlanCommand. I agree with the approach of this PR though, sinceatlantis planis equivalent toatlantis plan -d .so at least people have a way to connect to terraform cloud withoutatlantis.yamlnow. For more complex use cases,atlantis.yamlshould probably be defined. - The older configs to connect to terraform cloud with
backend "remote"block, which is replaced by thecloudblock, will still not be supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR fix #2171