fix: prevent commit status update in incorrect MR #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelmzs
changed the title
jamengual
added
waiting-on-review
|
@michelmzs Thanks for the contribution |
jamengual
approved these changes
Nov 4, 2022
|
Since going from v0.20.1 to v0.21.x the existing pipeline and the external atlantis pipeline no longer correlate and we get two pipelines linked to the commit instead of one with all stages combined. Atlantis now always create its own unique pipeline id. I can't find anything except this change which is related. Filed #2743 |
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
* fix: prevent commit status in incorrect MR - closes runatlantis#2484 * chore: update test 'TestGitlabClient_UpdateStatus'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevent Atlantis from updating the commit status on an incorrect Merge Request by passing the Ref (HeadBranch) in the CommitStatusOptions.
Tests
Tested on gitlab.com (v15.x) and Self-hosted (v14.x)
Closes #2484