Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): website: upgrade vuepress 0.x to 1.x #2828

Merged
merged 2 commits into from Dec 19, 2022

Conversation

krrrr38
Copy link
Contributor

@krrrr38 krrrr38 commented Dec 19, 2022

what

why

Currently, we use vuepress 0.x.

discussion

  • how abount vuepress 2.x?
    • 2.x is beta
    • If it's possible to upgrade, it is better to upgrade step by step.

references

@krrrr38 krrrr38 marked this pull request as ready for review December 19, 2022 11:16
@krrrr38 krrrr38 requested a review from a team as a code owner December 19, 2022 11:16
ga: "UA-6850151-3",
plugins: [
['@vuepress/google-analytics', { ga: "UA-6850151-3", }]
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// https://vuepress.vuejs.org/theme/inheritance.html#usage
module.exports = {
extend: '@vuepress/theme-default'
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before setting this, CustomHome doesn't show navbar. So add this setting and mv components/CustomHome.vue into theme/components/Home.vue

$homeWidth = 960px
$buttonColor = #34be68
$darkBackground = rgb(250, 250, 250)
.container
padding-top 3.6rem
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

custom-layout is disappeared. So add padding-top into Home.vue container for navbar.

image

@krrrr38
Copy link
Contributor Author

krrrr38 commented Dec 19, 2022

deploy/netlify is failed by node version. could you change this like node v14 which is same with this.

8:15:08 PM: Now using node v8.17.0 (npm v6.13.4)
8:15:18 PM: error is-plain-obj@3.0.0: The engine "node" is incompatible with this module. Expected version ">=10".

https://app.netlify.com/sites/runatlantis/deploys/63a047b25b06910008582742


.node-version is available.

https://docs.netlify.com/configure-builds/manage-dependencies/#node-js-and-javascript

@@ -0,0 +1 @@
14.21.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we bump this to node 16.x since that's the latest lts? Or should we do that in a separate pr?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we can bump it in a separate PR and check with netlify deployment.

@nitrocode
Copy link
Member

This is great. Nice work!

I think we can wait on upgrading to vue 2.x until it's out of beta.

@runatlantis/maintainers i clicked around on the preview website and it looks pretty good. Please take a second look.

@chenrui333 chenrui333 changed the title docs: upgrade vuepress 0.x to 1.x website: upgrade vuepress 0.x to 1.x Dec 19, 2022
@chenrui333 chenrui333 merged commit 3a61a3d into runatlantis:main Dec 19, 2022
@chenrui333
Copy link
Member

Thanks @krrrr38!

@nitrocode nitrocode added this to the 0.22.0 milestone Dec 23, 2022
@nitrocode nitrocode changed the title website: upgrade vuepress 0.x to 1.x chore(deps): website: upgrade vuepress 0.x to 1.x Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants