Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovate: maintenance renovate config/ci #2832

Merged
merged 6 commits into from
Dec 19, 2022

Conversation

krrrr38
Copy link
Contributor

@krrrr38 krrrr38 commented Dec 19, 2022

// use LTS node version for node docker image
matchDatasources: ["docker"],
matchPackageNames: ["node"],
versioning: "node",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodejs versioning use LTS

https://docs.renovatebot.com/node/

@krrrr38 krrrr38 marked this pull request as ready for review December 19, 2022 19:31
@krrrr38 krrrr38 requested a review from a team as a code owner December 19, 2022 19:31
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3.2.0
- uses: suzuki-shunsuke/github-action-renovate-config-validator@v0.1.2
Copy link
Contributor Author

@krrrr38 krrrr38 Dec 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I choose https://github.com/suzuki-shunsuke/github-action-renovate-config-validator, not
https://github.com/rinchsan/renovate-config-validator by following reasons.


In addition, https://github.com/renovatebot/github-action doesn't support validation like renovatebot/github-action#548.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action has very few stars. Is there not an action that is more widely accepted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems no other marketplace github actions for it. Otherwise we can do apt install npm && npx --package renovate -c 'renovate-config-validator'. Is this better? (for me both ok)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it and found that there is no reason to use marketplace action, so change it.

krrrr38 and others added 2 commits December 20, 2022 05:21
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
@nitrocode nitrocode merged commit d33bd0f into runatlantis:main Dec 19, 2022
@nitrocode
Copy link
Member

Thank you again @krrrr38 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants