bugfix: Add GetIsDeleted() check to Azure DevOps Event Handler

[SSKLCP]

what

Changing property check for isDeleted to ADO function GetIsDeleted() as that handles when the property doesn't exist

why

Issues when IsDeleted doesn't exist.

references

• Closes Atlantis panics on Azure DevOps comment when using v0.22.0-pre.20221219 #2834
• Closes Revert "Adding a check for deleted comments in AzureDevOps (#2804)" #2836

[jsw1993]

Is it possible to add a test for a comment without the IsDeleted field?

[SSKLCP]

@jsw1993 - See the attempted fix for this.

Ideally I wanted a test to say "If it's a valid request then pass" but because of the way it works, it tries to go to the repo URL to get the data and I'm not sure there is a valid repo to point at to test.
The line is here:

atlantis/server/controllers/events/events_controller.go

Line 638 in cf8db0c

baseRepo, err := e.Parser.ParseAzureDevopsRepo(resource.PullRequest.GetRepository())

Instead I've added a test which passes if it gets to (and fails) at the parsing section so at least we know that it's passed the ignore conditions.
If you have any better ideas on how to handle it let me know and I'm happy to implement

[jsw1993]

Sounds good to me but I'll let someone more versed in Go provide a proper judgement. Many thanks.

[nitrocode]

Thank you @SSKLCP for the quick fix!

[krrrr38]

LGTM, thank you!

[nitrocode]

@SSKLCP since #2850 is merged, do we need any changes in this pr or are we good to merge?

[SSKLCP]

@nitrocode - I've just changed the test to match #2850's testing pattern but other than that I'm happy so long as others are.
Thanks 😃

[nitrocode]

Nice work!