Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): website: node18 #2842

Merged
merged 3 commits into from
Dec 20, 2022
Merged

chore(deps): website: node18 #2842

merged 3 commits into from
Dec 20, 2022
+20 −66

Conversation

krrrr38
Copy link
Contributor

@krrrr38 krrrr38 commented Dec 20, 2022 •
edited

what

  • upgrade node from 14 to 18
  • add NODE_OPTIONS=--openssl-legacy-provider settings on yarn website:build
  • remove ghcr.io/runatlantis/ci-link-checker dependency
    • Before do it, we need to update ci-link-checker first to upgrade nodejs
    • This image is small, so just do it in the .circleci/config.yml which installs maffet/http-server.

why

latest nodejs LTS is 18

references

@krrrr38 krrrr38 marked this pull request as ready for review December 20, 2022 20:24
@krrrr38 krrrr38 requested a review from a team as a code owner December 20, 2022 20:24
@krrrr38 krrrr38 marked this pull request as draft December 20, 2022 20:25
@krrrr38 krrrr38 force-pushed the feat-node18 branch 4 times, most recently from 37c5ac6 to 73dcf99 Compare December 20, 2022 21:20
@krrrr38 krrrr38 marked this pull request as ready for review December 20, 2022 21:26
krrrr38
krrrr38 commented Dec 20, 2022
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
@nitrocode nitrocode merged commit ce8c89b into runatlantis:main Dec 20, 2022
@nitrocode
Copy link
Member

Yes! Thank you for no longer requiring the custom docker container and upgrading the node version to the latest LTS. Nice job!

@nitrocode nitrocode added this to the 0.22.0 milestone Dec 23, 2022
@nitrocode nitrocode changed the title website: node18 chore(deps): website: node18 Dec 30, 2022
@albertorm95 albertorm95 mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krrrr38 @nitrocode