Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): rm pegomock experimental feature for smooth mock generation #2886

Merged

Conversation

krrrr38
Copy link
Contributor

@krrrr38 krrrr38 commented Dec 28, 2022

what

Please see 2 commits. make regen-mock commit is not needed to review.

why

pegomock fail randomly with --use-experimental-model-gen.

✘╹◡╹✘☆  pwd
/Users/krrrr38/dev/src/github.com/runatlantis/atlantis/server/events

✘╹◡╹✘☆  pegomock generate -m --use-experimental-model-gen --package mocks -o mocks/mock_project_command_builder.go ProjectCommandBuilder && echo $?
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x12ed75d]

goroutine 1 [running]:
github.com/petergtz/pegomock/modelgen/loader.GenerateModel({0xc00003210b, 0x2d}, {0x205aade5b, 0x15})
        /Users/krrrr38/dev/pkg/mod/github.com/petergtz/pegomock@v2.9.0+incompatible/modelgen/loader/loader.go:23 +0x21d
github.com/petergtz/pegomock/pegomock/filehandling.GenerateMockSourceCode({0xc0000b4340?, 0x2, 0xc0000a7980?}, {0x0, 0x0}, {0x205aade2c, 0x5}, {0x0, 0x0}, 0x0, ...)
        /Users/krrrr38/dev/pkg/mod/github.com/petergtz/pegomock@v2.9.0+incompatible/pegomock/filehandling/filehandling.go:102 +0x22d
github.com/petergtz/pegomock/pegomock/filehandling.GenerateMockFile({0xc0000b4340?, 0x13fa238?, 0x0?}, {0x205aade35, 0x25}, {0x0?, 0x2d?}, {0x205aade2c?, 0xc00009e600?}, {0x0, ...}, ...)
        /Users/krrrr38/dev/pkg/mod/github.com/petergtz/pegomock@v2.9.0+incompatible/pegomock/filehandling/filehandling.go:64 +0xa5
github.com/petergtz/pegomock/pegomock/filehandling.GenerateMockFileInOutputDir({0xc0000b4340, 0x2, 0x2}, {0xc0000320f4?, 0x44?}, {0x205aade35?, 0x25?}, {0x0, 0x0}, {0x205aade2c, ...}, ...)
        /Users/krrrr38/dev/pkg/mod/github.com/petergtz/pegomock@v2.9.0+incompatible/pegomock/filehandling/filehandling.go:40 +0x19a
main.Run({0xc0001aa000, 0x9, 0x9}, {0x13fbbb0?, 0xc000198010}, {0x13fbb90, 0xc000198000}, 0xc0000e6000, 0xc0000061a0?)
        /Users/krrrr38/dev/pkg/mod/github.com/petergtz/pegomock@v2.9.0+incompatible/pegomock/main.go:116 +0x2985
main.main()
        /Users/krrrr38/dev/pkg/mod/github.com/petergtz/pegomock@v2.9.0+incompatible/pegomock/main.go:37 +0x6b

xX_Xx☆  pegomock generate -m --use-experimental-model-gen --package mocks -o mocks/mock_project_command_builder.go ProjectCommandBuilder && echo $?
0

✘╹◡╹✘☆  pegomock generate -m --use-experimental-model-gen --package mocks -o mocks/mock_project_command_builder.go ProjectCommandBuilder && echo $?
0

✘╹◡╹✘☆  pegomock generate -m --use-experimental-model-gen --package mocks -o mocks/mock_project_command_builder.go ProjectCommandBuilder && echo $?
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x12ed75d]

goroutine 1 [running]:
github.com/petergtz/pegomock/modelgen/loader.GenerateModel({0xc00003210b, 0x2d}, {0x205790e5b, 0x15})
        /Users/krrrr38/dev/pkg/mod/github.com/petergtz/pegomock@v2.9.0+incompatible/modelgen/loader/loader.go:23 +0x21d
github.com/petergtz/pegomock/pegomock/filehandling.GenerateMockSourceCode({0xc0001b84e0?, 0x2, 0xc000113980?}, {0x0, 0x0}, {0x205790e2c, 0x5}, {0x0, 0x0}, 0x0, ...)
        /Users/krrrr38/dev/pkg/mod/github.com/petergtz/pegomock@v2.9.0+incompatible/pegomock/filehandling/filehandling.go:102 +0x22d
github.com/petergtz/pegomock/pegomock/filehandling.GenerateMockFile({0xc0001b84e0?, 0x13fa238?, 0x0?}, {0x205790e35, 0x25}, {0x0?, 0x2d?}, {0x205790e2c?, 0xc000191c90?}, {0x0, ...}, ...)
        /Users/krrrr38/dev/pkg/mod/github.com/petergtz/pegomock@v2.9.0+incompatible/pegomock/filehandling/filehandling.go:64 +0xa5
github.com/petergtz/pegomock/pegomock/filehandling.GenerateMockFileInOutputDir({0xc0001b84e0, 0x2, 0x2}, {0xc0000320f4?, 0x44?}, {0x205790e35?, 0x25?}, {0x0, 0x0}, {0x205790e2c, ...}, ...)
        /Users/krrrr38/dev/pkg/mod/github.com/petergtz/pegomock@v2.9.0+incompatible/pegomock/filehandling/filehandling.go:40 +0x19a
main.Run({0xc0001aa000, 0x9, 0x9}, {0x13fbbb0?, 0xc000198010}, {0x13fbb90, 0xc000198000}, 0xc0001d8690, 0xc0000061a0?)
        /Users/krrrr38/dev/pkg/mod/github.com/petergtz/pegomock@v2.9.0+incompatible/pegomock/main.go:116 +0x2985
main.main()
        /Users/krrrr38/dev/pkg/mod/github.com/petergtz/pegomock@v2.9.0+incompatible/pegomock/main.go:37 +0x6b

references

@krrrr38 krrrr38 force-pushed the disable-pegomock-experimental-feature branch from d08419a to d4d4dc8 Compare December 28, 2022 01:31
@krrrr38 krrrr38 force-pushed the disable-pegomock-experimental-feature branch from d4d4dc8 to fe87c24 Compare December 28, 2022 01:37
@krrrr38 krrrr38 force-pushed the disable-pegomock-experimental-feature branch from fe87c24 to 7da7270 Compare December 28, 2022 01:41
@krrrr38 krrrr38 marked this pull request as ready for review December 28, 2022 01:43
@krrrr38 krrrr38 requested a review from a team as a code owner December 28, 2022 01:43
@nitrocode nitrocode changed the title Disable pegomock experimental feature not to fail go generate randomly chore(build): rm pegomock experimental feature for smooth mock generation Dec 28, 2022
@nitrocode nitrocode merged commit 27b9897 into runatlantis:main Dec 28, 2022
@nitrocode
Copy link
Member

Nice! Thank you @krrrr38 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants