Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable bump-homebrew-action #2906

Merged
merged 3 commits into from
Jan 3, 2023
Merged

Disable bump-homebrew-action #2906

merged 3 commits into from
Jan 3, 2023

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Jan 2, 2023

what

  • Fix bump-homebrew-action token

why

  • use GitHub action to bump formula

tests

references

@nitrocode nitrocode requested a review from a team as a code owner January 2, 2023 19:21
@nitrocode nitrocode changed the title Update release.yml Fix bump-homebrew-action token Jan 2, 2023
@@ -63,4 +63,4 @@ jobs:

Created by https://github.com/mislav/bump-homebrew-formula-action
env:
COMMITTER_TOKEN: ${{ secrets.PUBLIC_REPO_ACCESS_TOKEN }}
COMMITTER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per discussions, i dont think this would work either as it needs a token to a homebrew-core fork.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it gets forked automatically. See the atmos prs that fork using the cloudpossebot

Example Homebrew/homebrew-core#119212

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenrui333 are you saying that we need to use a different token with more rights? Or that runatlantis org needs to create a homebrew-core fork?

What do you think the next steps are to ensure this works as expected?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runatlantis need to have a homebrew-core fork. And the token need to have write permission to do it.

We can discuss about it in the monthly meeting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I have disabled this for now to allow green checks upon release.

@nitrocode nitrocode mentioned this pull request Jan 3, 2023
@nitrocode nitrocode changed the title Fix bump-homebrew-action token Disable bump-homebrew-action Jan 3, 2023
@nitrocode nitrocode merged commit 1fc3dd1 into main Jan 3, 2023
@nitrocode nitrocode deleted the bump-homebrew-fix branch January 3, 2023 19:31
@nitrocode nitrocode added this to the 0.22.1 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants