-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable bump-homebrew-action #2906
Conversation
@@ -63,4 +63,4 @@ jobs: | |||
|
|||
Created by https://github.com/mislav/bump-homebrew-formula-action | |||
env: | |||
COMMITTER_TOKEN: ${{ secrets.PUBLIC_REPO_ACCESS_TOKEN }} | |||
COMMITTER_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per discussions, i dont think this would work either as it needs a token to a homebrew-core fork.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it gets forked automatically. See the atmos prs that fork using the cloudpossebot
Example Homebrew/homebrew-core#119212
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chenrui333 are you saying that we need to use a different token with more rights? Or that runatlantis org needs to create a homebrew-core fork?
What do you think the next steps are to ensure this works as expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runatlantis need to have a homebrew-core fork. And the token need to have write permission to do it.
We can discuss about it in the monthly meeting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I have disabled this for now to allow green checks upon release.
what
why
tests
references