Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(discardApprovalOnPlan): add missing conditional and tests #2913

Merged
merged 5 commits into from
Jan 3, 2023
Merged

fix(discardApprovalOnPlan): add missing conditional and tests #2913

merged 5 commits into from
Jan 3, 2023

Conversation

secustor
Copy link
Contributor

@secustor secustor commented Jan 3, 2023 •
edited by nitrocode

what

  • Implements a missing 'if' conditional and adds additional tests

why

  • The dismissApprovalOnPlan option has been executed without option to turn it off.

tests

  • This only has been tested by implementing new unit tests

references

@secustor secustor requested a review from a team as a code owner January 3, 2023 09:46
@secustor secustor mentioned this pull request Jan 3, 2023
Merged
@nitrocode nitrocode mentioned this pull request Jan 3, 2023
Merged
@secustor @nitrocode
Apply suggestions from code review
52fc5b5 
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
@nitrocode
Copy link
Member

Once the tests pass here, a new dev label will be 30 minutes after merging this PR.

@mcantinqc would you be able to test the new image before we release a 0.22.1 hotfix ?

@nitrocode
Copy link
Member

Thanks for the quick fix @secustor !

@nitrocode nitrocode added this to the 0.22.1 milestone Jan 3, 2023
@nitrocode nitrocode merged commit a508bdb into runatlantis:main Jan 3, 2023
@secustor secustor deleted the fix_remove_approval_flag branch January 3, 2023 16:25
@albertorm95 albertorm95 mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22.1
Development

Successfully merging this pull request may close these issues.

Discard approvals by default in v0.22.0 due to missing logic
2 participants
@secustor @nitrocode