Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: /api/plan and /api/apply endpoints #3013

Merged
merged 11 commits into from
Jan 24, 2023

Conversation

lilincmu
Copy link
Contributor

@lilincmu lilincmu commented Jan 19, 2023

what

why

The feature has become stable and was lacking an API doc.

references

@lilincmu
Copy link
Contributor Author

lilincmu commented Jan 19, 2023

I couldn't find out how to serve OpenAPI spec on vuepress, so I resorted to plain markdown file for the API doc. 😞

@lilincmu lilincmu marked this pull request as ready for review January 19, 2023 03:30
@lilincmu lilincmu requested a review from a team as a code owner January 19, 2023 03:30
@nitrocode nitrocode changed the title docs: Add API doc for api endpoints docs: /api/* endpoints Jan 19, 2023
@nitrocode nitrocode changed the title docs: /api/* endpoints docs: /api/plan and /api/apply endpoints Jan 19, 2023
@nitrocode nitrocode added the docs Documentation label Jan 21, 2023
@nitrocode nitrocode added this to the v0.23.0 milestone Jan 23, 2023
@github-actions github-actions bot added go Pull requests that update Go code website labels Jan 24, 2023
Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lilincmu lilincmu merged commit 677fa8f into runatlantis:main Jan 24, 2023
@jamengual
Copy link
Contributor

jamengual commented Jan 25, 2023 via email

@lilincmu
Copy link
Contributor Author

I'm using : ./atlantis server --config=atlantis-server-config.yaml and on that yaml I have api-secret

@jamengual The error "ignoring request since API is disabled" is returned when using below server side config and --config=atlantis-server-config.yaml param. Where did you add the api-secret? Was it under repos as well?

repos:
  # id can either be an exact repo ID or a regex.
  # If using a regex, it must start and end with a slash.
  # Repo ID's are of the form {VCS hostname}/{org}/{repo name}, ex.
  # github.com/runatlantis/atlantis.
- id: /.*/
  # branch is an regex matching pull requests by base branch
  # (the branch the pull request is getting merged into).
  # By default, all branches are matched
  branch: /.*/

  api-secret: "<redacted>"

@jamengual
Copy link
Contributor

jamengual commented Jan 25, 2023

so -config= is for server flag configs mine looks like:

gh-user: jamengual
gh-token: "GHTOKEN"
repo-allowlist: "*"
gh-webhook-secret: "webhooksecret"
repo-config: atlantis-repo-config.yaml
enable-diff-markdown-format: true
silence-vcs-status-no-plans: true
hide-prev-plan-comments: true 
log-level: debug
atlantis-url: "http://localhost:4141"
api-secret: "apisecret"

@jamengual
Copy link
Contributor

so it is not part of the Repo config that was my mistake, it is a server flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation go Pull requests that update Go code website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants