Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: markdown renderer incorrect ordering of arguments #3016

Merged
merged 1 commit into from
Jan 19, 2023
Merged

fix: markdown renderer incorrect ordering of arguments #3016

merged 1 commit into from
Jan 19, 2023
+1 −1

Conversation

krrrr38
Copy link
Contributor

@krrrr38 krrrr38 commented Jan 19, 2023 •
edited
Loading

what

fix markdown renderer configuration order

why

  • Even if disableApply, comment contains To apply this plan, comment: atlantis apply -d ..

tests

references

krrrr38
krrrr38 commented Jan 19, 2023
View reviewed changes
server/server.go
disableApply,
userConfig.DisableMarkdownFolding,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@krrrr38 krrrr38 marked this pull request as ready for review January 19, 2023 23:46
@krrrr38 krrrr38 requested a review from a team as a code owner January 19, 2023 23:46
@jamengual jamengual merged commit f8eba4b into runatlantis:main Jan 19, 2023
@jamengual jamengual added the bug Something isn't working label Jan 19, 2023
@jamengual
Copy link
Contributor

@krrrr38 Thanks for the Fix.

@nitrocode nitrocode added this to the v0.23.0 milestone Jan 20, 2023
@nitrocode nitrocode changed the title fix: markdown renderer use invalid disableApply flag with disableMarkdownFolding fix: markdown renderer incorrect ordering of arguments Jan 20, 2023
@albertorm95 albertorm95 mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krrrr38 @jamengual @nitrocode