Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): Add missing dir to DRY repo level atlantis.yaml projects key #3099

Merged
merged 1 commit into from Feb 6, 2023
Merged

fix(docs): Add missing dir to DRY repo level atlantis.yaml projects key #3099

merged 1 commit into from Feb 6, 2023

Conversation

tieum
Copy link
Contributor

@tieum tieum commented Feb 3, 2023 •
edited by nitrocode

what

  • add missing required dir to projects

why

  • example of DRYing up the project config is missing the dir value
  • provided example gave the error parsing atlantis.yaml: projects: (0: (dir: cannot be blank.).). , with the extra dir value it works

references

  • none

@tieum tieum requested a review from a team as a code owner February 3, 2023 15:20
@github-actions github-actions bot added the docs Documentation label Feb 3, 2023
nitrocode
nitrocode approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nitrocode nitrocode changed the title [doc] fix repo level atlantis.yaml doc fix(docs): Add missing dir to DRY repo level atlantis.yaml projects key Feb 5, 2023
@nitrocode nitrocode merged commit 3023ef9 into runatlantis:main Feb 6, 2023
@nitrocode nitrocode added this to the v0.23.0 milestone Feb 7, 2023
@albertorm95 albertorm95 mentioned this pull request May 19, 2023
Merged
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@tieum @ijames-gc
fix repo level atlantis doc (runatlantis#3099)
6b8f263 
Co-authored-by: Matthieu Simon <matthieu.simon-ext@kering.com>
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@tieum @ijames-gc
fix repo level atlantis doc (runatlantis#3099)
7ec77f2 
Co-authored-by: Matthieu Simon <matthieu.simon-ext@kering.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

Assignees
No one assigned
Labels
docs Documentation
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tieum @nitrocode