Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clone): omit checkout depth if it is zero for git clone #3185

Merged
merged 1 commit into from Mar 3, 2023
Merged

fix(clone): omit checkout depth if it is zero for git clone #3185

merged 1 commit into from Mar 3, 2023

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Mar 3, 2023 •
edited

what

  • omit checkout depth if it is zero

why

  • git 2.32.0 does not like --depth=0, we use git 2.39.1
  • in this PR, we omit the depth if the depth is zero which checks out all the commits in the branch

tests

  • I have tested my changes by

references

@nitrocode nitrocode requested a review from a team as a code owner March 3, 2023 03:27
@github-actions github-actions bot added the go Pull requests that update Go code label Mar 3, 2023
@nitrocode nitrocode added this to the v0.23.2 milestone Mar 3, 2023
@jamengual jamengual merged commit 47cb6bd into main Mar 3, 2023
@jamengual jamengual deleted the omit-depth-0-checkout branch March 3, 2023 03:54
@nitrocode nitrocode mentioned this pull request Mar 3, 2023
Merged
@nitrocode nitrocode changed the title fix(clone): omit checkout depth if it is zero fix(clone): omit checkout depth if it is zero for git clone Mar 3, 2023
@albertorm95 albertorm95 mentioned this pull request May 19, 2023
Merged
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@nitrocode @ijames-gc
fix(clone): omit checkout depth if it is zero (runatlantis#3185)
e4fa26c
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@nitrocode @ijames-gc
fix(clone): omit checkout depth if it is zero (runatlantis#3185)
c3ffe67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code
Projects
None yet
Milestone
v0.23.2
Development

Successfully merging this pull request may close these issues.

Git clone fails after upgrading to 0.23.1
2 participants
@nitrocode @jamengual