fix(tests): prevent test git commands from modifying local files #3262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests would mutate $HOME/.gitconfig and $HOME/.git-credentials. Set the HOME environment variable to a suitable temporary directory before running git commands that mutate the global config. Fixes runatlantis#2604
jamengual
approved these changes
Mar 24, 2023
|
thanks @finnag |
nitrocode
changed the title
nitrocode
pushed a commit
that referenced
this pull request
May 5, 2023
The tests would mutate $HOME/.gitconfig and $HOME/.git-credentials. Set the HOME environment variable to a suitable temporary directory before running git commands that mutate the global config. Fixes #2604
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
) The tests would mutate $HOME/.gitconfig and $HOME/.git-credentials. Set the HOME environment variable to a suitable temporary directory before running git commands that mutate the global config. Fixes runatlantis#2604
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
) The tests would mutate $HOME/.gitconfig and $HOME/.git-credentials. Set the HOME environment variable to a suitable temporary directory before running git commands that mutate the global config. Fixes runatlantis#2604
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Tests no longer write to .gitconfig and .git-credentials in $HOME.
why
Tests should not write to git configuration files directly in the user's home directory.
tests
make test-allRreproduction steps to see the problem (fails without this patch):
references
closes #2604