fix(autoplan): modules for per-repo configs

[jukie]

what

• Moves FindModuleProjects outside of conditional which was only being run if per-repo config wasn't present
• Updates DetermineProjectsViaConfig to consume dependent module info
• Fixes a bug in findModuleDependants where only parent dirs one level up would be matched.
  • e.g. project at /some/terraform/project/path and module at /modules/path/ wouldn't work as intended

why

Autoplanning on dependent modules when using per-repo configs

tests

Tested with a docker image build and self-hosted Gitlab

references

• Related Nil pointer error when manually running "atlantis plan" on Gitlab after upgrading Atlantis to 0.23.2 #3196
• Fixes Autoplan modules functionality not working with per-repo config #3122

[jukie]

@nitrocode if you could check this on out please

[nitrocode]

Thanks again @jukie ! Please feel free to continue fixing stuff. It's very much appreciated!

[wyardley]

Thanks @jukie!

[bobziuchkovski]

@nitrocode Any chance I could talk you into cutting a new Atlantis release with these changes? We'd absolutely love to enable the module autoplanning on our Atlantis instance using per-repo config.

[nitrocode]

@bobziuchkovski we plan to release 0.23.4 soon. For now, could you use the dev tagged release until the new release?

[wyardley]

@jukie just wanted to say thanks for this! We needed this, and didn't get around to trying to fix it here.

We just rolled it out after the recent release, and can confirm that it seems to work perfectly as expected so far! Really simplifies our config and reduces the need to explicitly declare module dependencies.