Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): push docker dev tag only on merge to main #3393

Merged
merged 1 commit into from May 12, 2023
Merged

fix(ci): push docker dev tag only on merge to main #3393

merged 1 commit into from May 12, 2023

Conversation

GenPage
Copy link
Member

@GenPage GenPage commented May 10, 2023 •
edited by nitrocode

what

  • Disables pushing a dev tag within an unmerged pr commit event.
  • Also disabled image pushing at all unless the event comes from the main branch

why

Currently, the workflow updates the dev tag on unmerged pr commit events. This should only happen on the main branch. This is additional logic to prevent such possibilities

tests

  • I have tested my changes by testing in a separate fork

references

@GenPage
fix(ci): only push docker dev tag on main
542e6f1 
- Disables pushing a dev tag within an unmerged pr commit event.
- Also disabled pushing at all unless the event comes from the main branch
@GenPage GenPage requested a review from a team as a code owner May 10, 2023 03:00
This was referenced May 11, 2023
Closed
Open
@GenPage
Copy link
Member Author

GenPage commented May 11, 2023

Tests:

@nitrocode nitrocode changed the title fix(ci): only push docker dev tag on main fix(ci): push docker dev tag only on merge to main May 12, 2023
@nitrocode nitrocode merged commit 3c27fbb into main May 12, 2023
22 checks passed
@nitrocode nitrocode deleted the fix/dev-image-tags-on-pr branch May 12, 2023 02:34
@albertorm95 albertorm95 mentioned this pull request May 19, 2023
Merged
@nitrocode nitrocode added this to the v0.24.0 milestone May 22, 2023
mtavaresmedeiros pushed a commit to mtavaresmedeiros/atlantis that referenced this pull request Jul 3, 2023
@GenPage
fix(ci): only push docker dev tag on main (runatlantis#3393)
b8b85ad 
- Disables pushing a dev tag within an unmerged pr commit event.
- Also disabled pushing at all unless the event comes from the main branch
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@GenPage @ijames-gc
fix(ci): only push docker dev tag on main (runatlantis#3393)
7d9de64 
- Disables pushing a dev tag within an unmerged pr commit event.
- Also disabled pushing at all unless the event comes from the main branch
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@GenPage @ijames-gc
fix(ci): only push docker dev tag on main (runatlantis#3393)
f4ce569 
- Disables pushing a dev tag within an unmerged pr commit event.
- Also disabled pushing at all unless the event comes from the main branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@nitrocode nitrocode nitrocode approved these changes

Assignees

@nitrocode nitrocode

Labels
github-actions
Projects
None yet
Milestone
v0.24.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GenPage @jamengual @nitrocode