Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Pin ngrok to v2 and use https #3429

Merged
merged 4 commits into from May 22, 2023
Merged

fix(tests): Pin ngrok to v2 and use https #3429

merged 4 commits into from May 22, 2023

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented May 22, 2023

what

  • Pin ngrok to v2 e2e-deps.sh
  • Use https proto

why

  • v3 became the stable version recently and we haven't updated our scripts yet. This is a temporary change until we upgrade to ngrok v3.
  • http proto was deprecated so it returned an empty string

Error with localhost

2023/05/22 14:05:38 cleaning workspace /tmp/atlantis-tests
2023/05/22 14:05:38 creating atlantis webhook with http://localhost:4141/events url
2023/05/22 14:05:39 error creating atlantis webhook: POST https://api.github.com/repos/runatlantis/atlantis-tests/hooks: 422 Validation Failed [{Resource:Hook Field: Code:custom Message:Sorry, the URL host localhost is not supported because it isn't reachable over the public Internet}]

What we should see

2023/05/13 02:51:56 cleaning workspace /tmp/atlantis-tests
2023/05/13 02:51:56 creating atlantis webhook with http://c0e6-3-237-188-8.ngrok.io/events url
2023/05/13 02:51:56 https://api.github.com/repos/runatlantis/atlantis-tests/hooks/414310601

tests

  • I have tested my changes by branch tests for this pr
$ curl -s 'http://localhost:4040/api/tunnels' | jq -r '.tunnels[] | select(.proto=="http") | .public_url'
<empty>
$ curl -s 'http://localhost:4040/api/tunnels' | jq -r '.tunnels[] | select(.proto=="https") | .public_url'
https://snip.ngrok.io

references

  • export ATLANTIS_URL=$(curl -s 'http://localhost:4040/api/tunnels' | jq -r '.tunnels[] | select(.proto=="http") | .public_url')

@nitrocode nitrocode requested a review from a team as a code owner May 22, 2023 13:45
@nitrocode nitrocode changed the title Pin ngrok to v2 e2e-deps.sh fix(tests): Pin ngrok to v2 and use https May 22, 2023
@nitrocode nitrocode enabled auto-merge (squash) May 22, 2023 15:04
@nitrocode nitrocode merged commit f5c7814 into main May 22, 2023
12 checks passed
@nitrocode nitrocode deleted the ngrok-v2 branch May 22, 2023 15:11
@nitrocode nitrocode added this to the v0.24.0 milestone Jun 3, 2023
mtavaresmedeiros pushed a commit to mtavaresmedeiros/atlantis that referenced this pull request Jul 3, 2023
* fix(tests): Pin ngrok to v2 and use https
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
* fix(tests): Pin ngrok to v2 and use https
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
* fix(tests): Pin ngrok to v2 and use https
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants