Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dockerignore to speedup docker build #347

Merged
merged 1 commit into from Nov 9, 2018

Conversation

jocelynthode
Copy link
Contributor

This docker really speeds up the docker build as we do not have to send the entire repository to the docker daemon. We only send the files it actually needs

@codecov
Copy link

codecov bot commented Nov 9, 2018

Codecov Report

Merging #347 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #347   +/-   ##
=======================================
  Coverage   70.67%   70.67%           
=======================================
  Files          61       61           
  Lines        3655     3655           
=======================================
  Hits         2583     2583           
  Misses        893      893           
  Partials      179      179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52b3fd...d630bd7. Read the comment docs.

Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small change.

.dockerignore Outdated Show resolved Hide resolved
@lkysow lkysow merged commit b63f569 into runatlantis:master Nov 9, 2018
@jocelynthode jocelynthode deleted the add_dockerignore branch November 9, 2018 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants