Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump pegomock v3.0.1 #3515

Merged
merged 1 commit into from Jun 13, 2023
Merged

chore(deps): bump pegomock v3.0.1 #3515

merged 1 commit into from Jun 13, 2023

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Jun 13, 2023 •
edited

what

  • bump pegomock v3.0.1
go get github.com/petergtz/pegomock/v3
sed 's,\. "github.com/petergtz/pegomock",\. "github.com/petergtz/pegomock/v3",g' -i **/*.go
sed 's,"github.com/petergtz/pegomock",pegomock "github.com/petergtz/pegomock/v3",g' -i **/*.go
go mod tidy

why

  • latest v3.0.1 (May 4 2023)
    • v4.0.0 was released (May 11 2023) recently but I'm more hesitant to adopting the latest major version without at least a couple patches.

tests

  • I have tested my changes by running tests

references

@nitrocode nitrocode requested a review from a team as a code owner June 13, 2023 03:08
@github-actions github-actions bot added dependencies PRs that update a dependency file go Pull requests that update Go code provider/azuredevops provider/github provider/gitlab labels Jun 13, 2023
@nitrocode nitrocode force-pushed the pegomock-v3 branch 2 times, most recently from a80268a to 86dd14c Compare June 13, 2023 03:19
@github-actions github-actions bot removed the dependencies PRs that update a dependency file label Jun 13, 2023
@github-actions github-actions bot added the dependencies PRs that update a dependency file label Jun 13, 2023
@nitrocode nitrocode added this to the v0.24.3 milestone Jun 13, 2023
@nitrocode nitrocode enabled auto-merge (squash) June 13, 2023 03:28
@nitrocode
Copy link
Member Author

cc: @Almenon since you requested upgrading this package in #3402

@nitrocode
Copy link
Member Author

cc @jamengual @GenPage please review when you get a chance. Also please do not merge from the main branch or it will take longer to pass the tests.

jamengual
jamengual approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitrocode nitrocode merged commit e505817 into main Jun 13, 2023
21 checks passed
@nitrocode nitrocode deleted the pegomock-v3 branch June 13, 2023 18:36
@Almenon
Copy link
Contributor

Almenon commented Jun 14, 2023

Thanks!

This was referenced Jun 14, 2023
Closed
Open
mtavaresmedeiros pushed a commit to mtavaresmedeiros/atlantis that referenced this pull request Jul 3, 2023
@nitrocode
chore(deps): bump pegomock v3.0.1 (runatlantis#3515)
b5a9483
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@nitrocode @ijames-gc
chore(deps): bump pegomock v3.0.1 (runatlantis#3515)
dc0b188
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@nitrocode @ijames-gc
chore(deps): bump pegomock v3.0.1 (runatlantis#3515)
2686c0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

Assignees
No one assigned
Labels
dependencies PRs that update a dependency file go Pull requests that update Go code provider/azuredevops provider/github provider/gitlab
Projects
None yet
Milestone
v0.24.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nitrocode @Almenon @jamengual