Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): website: Upgrade patch release of vuepress #3595

Closed
wants to merge 2 commits into from

Conversation

lukemassa
Copy link
Contributor

@lukemassa lukemassa commented Jul 12, 2023

what

Small patch upgrade of vuepress, from 2.0.0-beta60 to 2.0.0-beta65

why

I noticed browsing https://www.runatlantis.io/docs/ that Luke Kysow's name appeared twice as a contributor.
Screenshot 2023-07-12 at 1 05 03 PM

I tracked this down to a bug in vuepress itself, which I was able to put in a fix for: vuepress/core#1364, which was subsequently released: https://github.com/vuepress/vuepress-next/blob/main/CHANGELOG.md. It turned out to treat automated commits different from manual ones, and the vuepress team agreed to merge them before showing on contributor field.

Now if I run the runatlantis.io site locally, you only see one:

Screenshot 2023-07-12 at 1 03 46 PM

I'm not sure of the cadence of updating this kind of dependency for Atlantis, I was just excited to get the fix in and wanted to bring it full circle to update it on the website here :) Feel free to close this if this bug doesn't seem important enough to have a dependency release "off cycle"; I'm happy to wait until it happens naturally.

tests

I ran the website locally and it fixed the issue (see above). I also clicked around a bit and everything seemed ok.

references

vuepress/core#1364

@lukemassa lukemassa requested a review from a team as a code owner July 12, 2023 17:13
@lukemassa
Copy link
Contributor Author

Looking at the error above, it looks like this probably requires a yarn update as well. When I ran it, at least locally, it produced a number of unexpected changes that I don't understand. If someone on the Atlantis side wants to push this through to fix the bug, that'd be great, otherwise like I said I can wait for whenever this is handled as part of a normal upgrade process.

@jamengual
Copy link
Contributor

@lukemassa thanks for the contribution, can you check the errors please?

@github-actions github-actions bot added the dependencies PRs that update a dependency file label Jul 14, 2023
@lukemassa
Copy link
Contributor Author

@lukemassa thanks for the contribution, can you check the errors please?

Hi sorry @jamengual, I don't quite understand them. I assume it has something to do with my upgrading this package without upgrading the yarn.lock, however when I tried to run yarn install it changed in ways I wasn't expecting.

I'll just go ahead and close the PR, hopefully vuepress will be updated at some point in the future for this fix to go in.

Apologies for the noise, thanks!

@lukemassa lukemassa closed this Jul 14, 2023
@lukemassa
Copy link
Contributor Author

Hm, actually it looks like this PR #3600 made a similar change (though, despite the name, only to yarn.lock, not to package.json). It itself also ran into the same build failure: a88d2be, so not really sure what's going on there

@lukemassa
Copy link
Contributor Author

FYI #3611 ended up pushing out this change, so now the website has the fix! :)

Screenshot 2023-07-26 at 12 09 38 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies PRs that update a dependency file website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants