fix: Check user permissions on autoplan #3742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meringu
changed the title
jamengual
added
waiting-on-review
GenPage
previously approved these changes
Sep 25, 2023
GenPage
added
needs tests
|
I think the tests need to be updated since they are failing on CreateComment |
|
Hey @GenPage. Thanks for taking a look. I've updated the failing tests, and changed what I assume is a typo of conftest. |
|
Hi @GenPage , are we able to remove the "waiting-on-response" label for this one? Please let me know if there is anything I can do to help progress. |
|
Looks like it is failing now on installing Alpine packages? I'm not entirely sure if this is related to my change. |
|
Sorry to keep chasing up @jamengual, would this now need the "waiting-on-review" label? |
jamengual
added
waiting-on-review
jamengual
approved these changes
Nov 15, 2023
|
/cherry-pick release-0.26 |
|
/cherry-pick release-0.26 |
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* Check user permissions on autoplan --------- Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* Check user permissions on autoplan --------- Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This change enforces the team permissions on autoplans. Currently Atlantis will autoplan any PR when a team is configured.
why
The current behavior is a security risk for us. We have a large number of teams sharing the same GitHub org. We want to encourage inner-sourcing and collaboration by allowing forks from other teams within the orgs, but these PRs we don't trust until they have been reviewed by a team member that owns the project.
tests
We having been running this for a number of months internally on a small handful of repositories. This was the only vulnerability we could find when using Atlantis team permissions with our team and trust model on GitHub.
references